Release 0.2.0 - #17
Merged
Merged
Conversation
Minor, not patch: mx_crypto_room_key_payload() takes four further required arguments, so five-argument calls now error. NEWS collapsed from 0.1.1.1-0.1.1.5 into one section grouped security / breaking / new / other. cran-comments rewritten from the first-submission text.
Those runs were never made. Listing only what was actually run: Ubuntu 24.04 R 4.5.3, Windows 10 R 4.6.0, and Windows R-devel.
R CMD build packages the working directory, not the git tree, and skips only a fixed set of dot-entries. Anything untracked in the package root ships. CI checks out a clean tree and can never see it, so this has to run locally before submission. Ported from whisper with an allowlist matching what this package ships. Excluded from the tarball via .Rbuildignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor, not patch:
mx_crypto_room_key_payload()gained four required arguments, so five-argument calls now error.Collapses 0.1.1.1-0.1.1.5. Headline is the E2EE security work: homeserver-supplied keys are verified before use, Olm payloads carry the spec-required
sender/recipient/recipient_keys/keysblock, inbound payloads are checked against this device's identity, andsender_verifiedis only TRUE when the claimed identity binds to a verified device.Verified live, not just by loopback
Against the Conduit homeserver with mx.client 0.2.0:
/keys/query: 7 of 7 devices verified, zero warnings — cornelius plus six real client devices. The risk was a verifier too strict for legitimate devices; it isn't./keys/claim: a real client-signed one-time key accepted.m.room.encrypted, Megolm, ciphertext present, no cleartext body.Verification
R CMD check --as-cran: 0 errors, 0 warnings, 0 notes