Keep POST /v1/videos/generations for backwards compatibility - #69
Merged
Merged
Conversation
The move to the /v1/videos job contract removed the legacy synchronous video endpoint. Restore it: POST /v1/videos/generations again returns the mp4 bytes inline (no job), alongside the new POST /v1/videos create/poll/ download. Validation and generation are shared (.dserve_video_render), so the two paths cannot drift. test_serve.R covers both (47 assertions).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.2.2.11 moved diffuseR::serve's video endpoint to the
/v1/videosjobcontract but removed the legacy synchronous
POST /v1/videos/generations.This restores that endpoint for backwards compatibility: it again returns
the mp4 bytes inline (no job), alongside the new create/poll/download.
Validation and generation are shared (
.dserve_video_render), so the twopaths cannot drift.
test_serve.Rcovers both (47 assertions pass againstsource).