Document chat_edit()'s rich argument - #21
Merged
Merged
Conversation
chat_edit() gained rich alongside chat_send()'s without a @PARAM, and R CMD check has warned about the undocumented argument since. The sibling sentence on chat_send()'s rich also lost its subject: it is chat_capabilities()$rich_markup that adapters ignore it on when empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs only, no bump.
chat_edit()gainedrichalongsidechat_send()'s (#11) without a@param, so every R CMD check since has carried:This adds the entry, and fixes the sibling sentence on
chat_send()'srich, which had lost its subject: it ischat_capabilities()$rich_markupbeing empty that makes an adapter ignore it.tools::checkDocFiles()on the source now reports nothing.