Persist Matrix key requests safely and pin the local master - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep decrypted Matrix sync batches intact when room-key request transport fails. The adapter now persists the mutated crypto state before sending any request, retries unsent requests with the same id, and treats cancellation or sent-marker persistence failures as warnings. This prevents a network failure from replaying the sync against already-advanced Olm ratchets.
Same-user forwarded-key recovery now queries devices with the master public key loaded from the local cross-signing store. Missing or unreadable local keys leave this user's devices untrusted for recovery. Reading the pin when querying also picks up bootstrap performed after the crypto context was initialized.
Required optional dependency increases: mx.client >= 0.2.0.8 and mx.crypto >= 0.2.1.1. The new request-state and cross-signing APIs require these floors.
This branch starts from current main (0.0.1.24), includes its newer thread/media behavior, and excludes the separate Slack lifecycle branch and NAMESPACE registrations. Version 0.0.1.25 is recorded in its own
Bump version to 0.0.1.25commit touching only DESCRIPTION and NEWS.md. CI configuration is a separate commit.Validation: all four final sources, including mx.crypto, were installed into a fresh isolated library. Full suites pass: chat.api 1092/1092, mx.client 315/315, mx.crypto 100/100, mx.api 208/208. Changed CI YAML and shell syntax pass local validation. Regression tests cover save/send/retry ordering and missing/corrupt/local-master behavior.
Landing prerequisites:
Expected temporary CI failures: the existing Matrix setup clones mx.api and mx.client from their GitHub default branches and enforces the mx.client floor. Linux also needs the new mx.crypto release from drat. The new crypto install explicitly bypasses rapt's older binary and checks the floor; macOS retains its existing optional-crypto split. Rerun CI after the upstream publication and mx.client merge. No package publication, bot deployment, or console/SAS verification is included here.