chat_edit() keeps the message's kind - #12
Merged
Merged
Conversation
Matrix carries the msgtype inside m.new_content, so the hardcoded m.text turned an m.notice into an ordinary message the first time an edit fired. That matters beyond tidiness: m.notice is what stops a bot's own output triggering other bots, and a progress trail that silently became m.text partway through a turn is exactly the kind of loop a room full of agents does not survive. The kind-to-msgtype mapping moves out of chat_send() so both use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matrix carries the msgtype inside
m.new_content, andchat_edit()hardcodedm.textin both there and the outer event. So editing anm.noticesilently converted it to an ordinary message the first time it fired.That matters beyond tidiness.
m.noticeis the marker that stops a bot's own output triggering other bots, and corteza's activity trail is about to be a notice that gets edited a dozen times a turn. A trail that quietly becamem.textpartway through is the kind of loop a room full of agents does not survive.chat_edit(..., kind = "message"), documented as needing to match what the message was sent as. The kind-to-msgtype mapping moves out ofchat_send()intomatrix_msgtype()so both use one implementation.901/901.