Skip to content

refactor(next): comprehensive SonarLint cleanup and zero-defect quality pass (#578) - #583

Merged
remiceres merged 1 commit into
feature/corese-nextfrom
feature/578-core-next-quality-pass
Sep 9, 2026
Merged

refactor(next): comprehensive SonarLint cleanup and zero-defect quality pass (#578)#583
remiceres merged 1 commit into
feature/corese-nextfrom
feature/578-core-next-quality-pass

Conversation

@remiceres

Copy link
Copy Markdown
Contributor

Closes #578

Summary

Comprehensive SonarLint cleanup and zero-defect quality pass across the entire fr.inria.corese.core.next module.

Changes

  • Scanned all 693 files in fr.inria.corese.core.next using live headless SonarLint LSP runner (tools/sonarlint_extract.py).
  • Resolved all remaining SonarLint issues (missing @Override, unused constructors, container membership regex precompilation, lambda simplification, redundant self-assignments, Javadoc comment syntax).
  • Removed legacy @SuppressWarnings("NullableProblems") across 12 files.
  • Removed empty package directory data/impl/io/jsonld.
  • Added tools tools/sonarlint_extract.py and tools/extract_sonar_alerts.py to automate Sonar extraction via IDE and headless LSP.
  • Preserved strict module boundary: 0 references or imports to legacy packages outside CoreseGraphStatementStore.java.
  • Verified all 2,794 unit tests and 2,327 W3C regression tests pass with 0 failures.

…ty pass (#578)

- Clean up temporal literals (SimpleDate, SimpleDateTime, SimpleDuration, SimpleTime) by removing unused 3-arg constructors and S1172 suppressions
- Remove all 19 non-standard NullableProblems suppressions across 12 files
- Add missing @OverRide annotations in Literal (S1161)
- Precompile regex pattern in RDFXMLStatementEmitter (S9142)
- Simplify AST visitor lambdas in DatasetClauseAst and DescribeQueryAst (S1602)
- Remove redundant self-assignment in PrefixDeclarationAst (S4165)
- Fix Javadoc comment syntax in RDFaParser (S9355)
- Remove empty package data/impl/io/jsonld (S4032)
- Align exception hierarchy depth suppressions with S110 in query/api/exception
- Add SonarLint extraction and headless LSP CLI tools in tools/
- Verify 100% zero defects on SonarLint across core.next, 10/10 boundary tests, and 0 W3C regressions
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Overall Project 53.06% 🍏
Files changed 93.42% 🍏

File Coverage
RepositoryException.java 100% 🍏
QueryTimeoutException.java 100% 🍏
QueryEvaluationException.java 100% 🍏
QuerySyntaxException.java 100% 🍏
StatementResult.java 100% 🍏
DescribeQueryAst.java 100% 🍏
SimpleDate.java 98.36% 🍏
SimpleTime.java 98.36% 🍏
SimpleDateTime.java 98.36% 🍏
SimpleDuration.java 98.1% 🍏
DatasetClauseAst.java 92.98% 🍏
PathMappingBuffer.java 90.77% 🍏
EmptyModel.java 90.38% 🍏
PrefixDeclarationAst.java 88.1% 🍏
AbstractCoreseQuery.java 80.56% 🍏
SimpleTriple.java 78.79% 🍏
RDFXMLStatementEmitter.java 78.46% -1.92%
MaterializedResults.java 77.59% 🍏
AbstractDuration.java 77.3% 🍏
StorageModel.java 77.02% 🍏
TupleQueryResult.java 70.27% 🍏
AbstractModel.java 67.19% 🍏
RDFaParser.java 65.97% 🍏
KgramEventDispatcher.java 22.92% 🍏
ReadOnlyModel.java 15.28% 🍏
ResultsImpl.java 0% 🍏

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Test Results

  424 files    424 suites   20s ⏱️
2 775 tests 2 775 ✅ 0 💤 0 ❌
2 794 runs  2 794 ✅ 0 💤 0 ❌

Results for commit 7fbe45a.

@remiceres
remiceres merged commit 377c1ca into feature/corese-next Sep 9, 2026
2 checks passed
@remiceres
remiceres deleted the feature/578-core-next-quality-pass branch September 9, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant