refactor(next): streamline AST execution bridges and eliminate query adapter layers (#576) - #580
Merged
remiceres merged 3 commits intoSep 9, 2026
Conversation
|
Test Results 425 files 425 suites 25s ⏱️ Results for commit 1af1045. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Streamlines and simplifies the execution bridge layers in
fr.inria.corese.core.next.query.impl.sparql.bridgeto eliminate unnecessary intermediate translation wrappers between the Next SPARQL AST and the query execution pipeline.Closes #576
Changes
SparqlTermResolver.toNode(TermAst), eliminating duplicated switch logic across bridge classes.CoreseAstQueryBuilderandNativeEvaluationContextwith direct calls totermResolver.toNode(term).simplePredicate(PathAst)toWhereCompilerwhere query and construct graph patterns are resolved.AstBackedExprTestcovering AST term resolution, literal parsing, filter views, variable bindings, and immutability contracts.Verification
./gradlew compileJava compileTestJava: SUCCESS (0 errors, 0 warnings)../gradlew test: 2,628 tests executed, 2,628 passed, 0 failures../gradlew enforceW3cRegressions: 2,327 stable passes, 0 regressions, 141 tests transitioned to passed.