[Next Query] Reorganize and modularize internal KGRAM engine packages (#575) - #579
Merged
remiceres merged 7 commits intoSep 8, 2026
Merged
Conversation
…ages (#575) - Move engine classes from legacy impl.kgram to impl.engine subpackages: - model: AST/graph node, edge, filter, expr models and types - spi: service provider interfaces (Producer, Evaluator, Matcher, Environment, etc.) - eval: core query evaluation loop and evaluator implementations - pattern: query patterns, expressions, and group structures - solution: solution mappings, memory state, and result tables - path: property path evaluations and path finding algorithms - filter: pattern matching filters and compilation - sorter: heuristic reordering and query optimization - event: listener dispatching and visitor interfaces - storage: temporary storage adapters and default producers - Add package-info.java with Javadoc across all 11 new engine packages (Sonar S1228) - Move and adapt engine unit tests under src/test/java/.../engine/ - Update NextModuleBoundaryTest and all codebase import references
Test Results 424 files 424 suites 22s ⏱️ Results for commit 7d40a9b. ♻️ This comment has been updated with latest results. |
… engine packages (#575)
|
|
|
|
|
… and query packages (#575)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR addresses issue #575 by reorganizing and modularizing the internal KGRAM execution engine under
fr.inria.corese.core.next.query.impl.engine(retiring the legacyimpl.kgramnamespace forcore.next).1. Package Reorganization & Modularization
Moved all classes from
impl.kgraminto 10 structured domain subpackages underfr.inria.corese.core.next.query.impl.engine:model: Graph patterns, node, edge, and filter models (Node,Edge,Filter,Expr,NodeImpl, etc.)spi: Service Provider Interfaces (Producer,Evaluator,Matcher,Environment,Plugin,AST, etc.)eval: Core query evaluation loop (Eval,SparqlException, etc.)pattern: Query pattern and plan structures (Query,Exp,Group,ExpEdge,BgpGenerator, etc.)solution: Query solution mappings and memory state (Mapping,Mappings,MappingSet,Memory,Merge)path: Property path evaluations and path finding algorithms (GraphPath,PathFinder,Automaton, etc.)filter: Pattern matching filters and expression compilation (Extension,Compile,Pattern, etc.)sorter: Query optimization, heuristics, and cost models (QuerySorter,Sorter,AbstractCostModel, etc.)event: Listener dispatching and visitor interfaces (EventManager,EventListener, etc.)storage: Storage manager adapters and producer implementations (StorageManagerProducer,StorageManagerEdge,ProducerDefault)2. Quality & Architecture
package-info.javawith complete Javadoc across all 11 engine packages (SonarLint S1228 compliance).engine.spi.ASTimports across the entire codebase.NextModuleBoundaryTest.3. Verification & Conformance
./gradlew testincorese-core: BUILD SUCCESSFUL (0 failures)../gradlew enforceW3cRegressionsincorese-w3c: 0 regressions, 2 327 stable passes, 141 tests transitioned to PASSED.Closes #575