Repository navigation
ci: publish releases only after GoReleaser uploads assets - #82
Merged
Merged
Conversation
release-please published the GitHub Release as soon as the release PR merged, so releases/latest/download/analyze.sh 404'd until GoReleaser finished uploading (~2.5 min), tripping the Sentry uptime monitor on every release. release-please now creates a draft (with force-tag-creation so the v* tag still triggers release.yml), and GoReleaser uploads to that draft via use_existing_draft and publishes it once the assets are in place. Fixes PATCHWAVE-ANALYSIS-CLI-3
blimmer
marked this pull request as ready for review
October 15, 2026 17:49
jcarver989
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-please publishes the GitHub Release as soon as the release PR merges, but GoReleaser uploads the assets a few minutes later. In that window
releases/latest/download/analyze.sh(and the binaries) return 404, sopatchwave.ai/analyze.shbreaks for anyone installing and the Sentry uptime monitor fires (PATCHWAVE-ANALYSIS-CLI-3). For v1.0.0 the release was published at 17:41:15 and the assets landed at 17:43:48.release-please now creates the release as a draft, and GoReleaser uploads to that draft and publishes it after every asset is in place.
latestkeeps pointing at the previous release until then. A failed release run now leaves an unpublished draft instead of a brokenlatest.Fixes PATCHWAVE-ANALYSIS-CLI-3
Review focus
force-tag-creationis required. GitHub doesn't create the tag for a draft release until it's published, so without this option thev*tag would never be pushed andrelease.ymlwould never run. The tag is still created with the app token, so it triggers workflows the same way it does today.use_existing_draftlooks up the draft by name. GoReleaser's defaultname_templateis{{ .Tag }}(v1.0.0), which matches the name release-please gives the release. If no draft is found, GoReleaser creates a new release, so a name mismatch would show up as a duplicate release.Commits
5b01804— ci: publish releases only after GoReleaser uploads assets