Repository navigation
[cpyrt] Rank standard conversions above implicit construction - #127
Merged
Merged
Conversation
compiler-research#75 defers enum instances out of the exact round for integer parameters so that an enum overload wins over an integer one. Two cases regress: an implicit construction from the argument runs under kNoImplicit, where the deferred enum -> int step is refused (RooFit::LineColor(kRed) with a TColorNumber(Int_t) parameter), and in the implicit round a class overload constructible from an int-like object is tried before the integer one (TStyle::SetPalette(kGreyScale) picks the TString overload). Let enum instances through the integer gate under kNoImplicit, and resolve overloads in three stages as C++ ranks them: exact matches, standard conversions (kNoImplicit), implicit conversions.
guitargeek
approved these changes
Oct 1, 2026
guitargeek
left a comment
guitargeek
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Thanks for following up on this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#75 defers enum instances out of the exact round for integer parameters so that an enum overload wins over an integer one. Two cases regress: an implicit construction from the argument runs under kNoImplicit, where the deferred enum -> int step is refused (RooFit::LineColor(kRed) with a TColorNumber(Int_t) parameter), and in the implicit round a class overload constructible from an int-like object is tried before the integer one (TStyle::SetPalette(kGreyScale) picks the TString overload). Let enum instances through the integer gate under kNoImplicit, and resolve overloads in three stages as C++ ranks them: exact matches, standard conversions (kNoImplicit), implicit conversions.