fix(cache): default SkyUI icons not showing - #7
Merged
Merged
Conversation
codepuncher
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most item and spell icons showed as tinted cubes with I5 installed.
On a cache miss, I5 passed I4 a stand-in object instead of SkyUI's list. Menus compiled with getter calls (Crafting Categories, NORDIC UI) read the list via
a_list.__get__entryList(), which the stand-in lacks, so SkyUI never seticonLabeland I5 cached the entry without it.I5 now passes the real list with its
_entryListswapped to the misses, and bumps the cache schema so broken caches are discarded.