fix(favorites): prevent I4 1.1.1 CTD when opening the Favorites menu - #3
Merged
Merged
Conversation
codepuncher
force-pushed
the
fix/favorites-ctd-i4-1-1-1
branch
from
September 26, 2026 02:39
2669266 to
70232fd
Compare
codepuncher
force-pushed
the
fix/favorites-ctd-i4-1-1-1
branch
2 times, most recently
from
September 26, 2026 03:16
aaf0d6d to
8f817dc
Compare
codepuncher
force-pushed
the
fix/favorites-ctd-i4-1-1-1
branch
from
September 26, 2026 03:17
8f817dc to
ad32ea8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the crash when opening the Favorites menu with I4 1.1.1.
I4 1.1.1 was built with CommonLib's 1.7.99
SkyrimVMlayout, so on 1.6.x itsGetNoIconColorsreads the VM pointer from the wrong offset. The next VM call jumps to0x656D6167and the game crashes. Only Favorites is affected: I4 callsGetNoIconColorsonly when the icon setter has no_noIconColorsmember, andFavoritesIconSetteris the only one without it.The fix hooks
FavoritesMenu::ProcessMessage, and when the menu is shown, sets_noIconColorson the setter before I4'sprocessListruns. I4 then skips its broken lookup. The value is read the same way I4 reads it (MCM override, thenconfig.txt), so "Disable Icon Colors" still works in Favorites.Related
Fixes #1