feat(helm): emit containment edges for resource templates, lookups, and aliases - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4. Contract side: codellm-devkit/codeanalyzer-schema#3 (commit
b84428f). Spec:docs/design/specs/2026-09-05-iac-containment-edges.mdin codellm-devkit/.github (#57). Epic codellm-devkit/.github#52.What changes
b84428f1accebe2b259d32c15387f04a00167f2ceverywhere (schema.json,schema.neo4j.json, embedded copies,live.yml, README,.claude/SCHEMA_DECISIONS.md), with a test that fails if any pin site drifts.IAC_HAS_RESOURCE_TEMPLATEandIAC_HAS_LOOKUP_REFERENCEfrom aHelmTemplateto each child inresource_templates{}/lookup_references{}, andIAC_HAS_ALIASfrom anArtifactto each entry in itsaliases[].model.Validateenforces one edge per nested child, mirroring the existing value-reference rule. The Neo4j projector and eager cleanup pick the new families up from the catalog with no new code.Why
DayTrader's five
*-service.yamltemplates each hold aServiceand a conditionalRoutedocument. Provenance (IAC_DERIVED_FROM) is attributed only for single-region files, so those tenHelmResourceTemplatenodes had no edge at all and were isolated in Neo4j.HelmLookupReferencenodes were unreachable, and aliases had no inbound owner edge.Evidence
After rewriting DayTrader (
sample.daytrader.microservices@8a68b59, three profiles) into Neo4j:18
IAC_HAS_RESOURCE_TEMPLATEedges for 18 resource templates, 1IAC_HAS_ALIAS. Gates:gofmt,go vet,go test ./...,-raceon helm/model/neo4j,make schema-check, jobs-determinism and level-subset ×5, semantic checker on fresh L1/L2/L3, Neo4j parity suite withCI=true,make test-live(DayTrader containment assertion included).