fix(release): run the release gate against a Neo4j service - #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9.
The first
v0.1.0run (34003621288) failed at the gate:make testincludestests/parity_test.go, whose graph gates are fatal underCIwithoutNEO4J_TEST_URI, and the release job had no Neo4j service. The fail-closed path worked (tag deleted, nothing published).This adds to the
releasejob the same Neo4j 5 service container andNEO4J_TEST_*env thatci.yml's "full suite with a graph" job uses, byte-identical. The gate stays the full suite.actionlintclean; onlyrelease.ymlchanges.