V10.0.1/fix versioning #2 - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the CI pipeline and build configuration to ensure the integrity and correctness of release packages. The main focus is on validating the release version and package before publishing, and on enforcing consistent version tagging. Below are the most important changes:
CI Pipeline Enhancements:
release_version_guardjob to.github/workflows/ci-pipeline.ymlthat validates the calculated release version after the build. This job ensures that a valid SemVer tag is present and prevents publishing if the version is a fallback (e.g.,0.0.0-alpha).packjob to depend on the newrelease_version_guard, ensuring that packaging only proceeds if the release version is validated..nupkgfile is produced, and that its filename, package id, and version match the expected values. This step also inspects the.nuspecfile inside the package for correctness, preventing accidental publication of invalid packages..nupkgfiles in the directory.Build Configuration Improvements:
Directory.Build.props, added logic to set theMinVerTagPrefixtovfor source projects, enforcing that only tags prefixed withvare recognized for versioning. [1] [2]These changes collectively improve the reliability of the release process by enforcing strict version and package validation before publication.