Reconcile the design plan with the code

[mchwang]

Summary

Docs only: docs/designs/codeboost-plan-indexed-review.md and docs/implementation/guarded-merge.md. It brings the approved plan in line with the code on main (checked 2026-09-26 against 5e97aa3).

Decisions recorded

• Ask is an interim exception to R1. runner/question-agent.ts runs the claude or codex CLI on the host, in a temporary folder, with tools, web and MCP off. It is limited to Ask. Lane D5 has merged (D5: Add the combined real-Docker isolation gate #50), so the container exists; the exception ends when lane F moves Ask onto D's invocation contract.
• D20 amended: no "Merge anyway". codeboost never merges while a blocker remains; to override one, merge on GitHub. This matches docs/implementation/guarded-merge.md and the rule that no override bypasses server-side base protection. The screen spec, step 9, the decision table and DT7 are updated.

Status brought up to date

• Increment 1 of build step 4 marked merged (Add guarded merge gate #23).
• New "Lane status" table: C, D and K done; E3 merged and E4 open (E4: add planning acceptance fixtures; await D5 recordings #45); F1 contract merged (F1: runner lifecycle and state-holder contract (for review) #49) with F1a–F1c open (F1a: persist the runner lifecycle in the Store #53, F1b: runner coordinator for attempts, slots and shutdown #56, F1c: shutdown wiring and /api/runner #57); H1–H3 and the Issues screen (H4a, H4a: add the ranked Issues screen #55) merged.
• T1, T2, T4, T5, T10, T13 and T14 ticked, each with the test names that prove its Verify line. T9 stays open until F6.
• Files lines point at core/linking.ts and core/approvals.ts; core/segments, core/choices and core/attribution were never created.
• Open questions: issue ranking (H1) and AgentDiff marked decided.
• Design tasks: verified status note. Nothing newly ticked; the gaps are the merge step list (D16), "Send N change requests" and the reject flow (D19), and the menu placeholders. The 1280px notice (D25) and ? help already exist.

guarded-merge.md no longer says merge-queue branches stay blocked: it points to merge-queue.md (#46) and notes that adapters without queue inspection still fail closed.

Historical review records (engineering findings, decision ledger, reviewer concerns) are unchanged.

Validation

Evidence on head a756f5b:

• npm run typecheck: passed.
• npm test using CI's excludes: 435 passed, 9 failed in history, review and store (real-git tests). The machine had a load average of about 116 with 168 Docker containers running. This PR changes only one Markdown file, so GitHub CI on this head is the result to use.
• Self-review of the full diff done under AGENTS.md; every status claim was checked against code, tests or gh pr view.

Review-lesson audit

No review findings yet.

Follow-ups (not in this PR)

• Lane F: move Ask into the container.

🤖 Generated with Claude Code

Readiness report

• Head: cbffd94. It marks the install preflight and npx entry as planned (the CLI checks only Node today), per Copilot's review of 49d5fcd. e5e4f05 added F1e F1e: planning API for lane G and feedback from review actions #60 and the D follow-ups required by the F1 runner lifecycle contract #51 merge condition to the F lane row. 49d5fcd corrects the README's merge-queue removal sentence, per Copilot's review of e5e4f05: a plain removal can be retried, and only a changed head needs a fresh review.
• CI: test passed on cbffd94.
• Mergeability: mergeable, no conflicts
• Unresolved review threads: 0 (all 3 resolved)
• Latest Copilot review (cbffd94): approval recommended, no findings.
• Files: docs/designs/codeboost-plan-indexed-review.md and README.md; docs only.
• Deferred follow-ups:
  • docs/designs/codeboost-plan-indexed-review.md:533 (L1: "rejected" closes a task) still conflicts with step 8 (Reject with feedback requeues the task). The F1 contract follows step 8 until this line is reconciled.
  • The README's Ask limit and the plan's R1 exception should be removed together when Run Ask in the lane D agent container #54 (Ask in the agent container) merges.

[Copilot]

Copilot review overview

🟡 Changes recommended

Documentation contains unresolved contradictions about merge queues, isolation limits, README status, and dependency checks.

Review effort: Lite
Findings: 1

Open (1)

• Remove obsolete queue-merging block instruction · New

What changed in this PR

This docs-only PR reconciles the design plan with the current implementation, lane progress, safety decisions, and remaining work.

Changes:

• Documents Ask’s interim host-CLI exception.
• Updates merge, isolation, milestone, and task statuses.
• Records validation evidence and implementation gaps.

File	Summary
docs/​designs/​codeboost-plan-indexed-review.md	Updated design decisions, implementation status, and roadmap progress.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved documentation contradictions and inaccurate implementation guidance remain.

Review effort: Lite
Findings: 1

Open (1)

• Remove obsolete queue-merging block instruction

Previously missed (1)

In code that hasn't changed since last review

Document or implement missing startup tool and provider checks

docs/​designs/​codeboost-plan-indexed-review.md:648

This says codeboost checks for gh, Docker/Podman, and at least one provider, but the current CLI only enforces the Node version; startServer does not probe those tools or require a provider, and the runner has not wired in the container boundary yet. Since this document is explicitly reconciled against main, please qualify these as feature-specific/future requirements or add the missing startup checks.

[Copilot]

Copilot review overview

🟡 Changes recommended

Documentation contains unresolved contradictions and claims that do not match the current implementation.

Review effort: Lite
Findings: 1 · 1

Open (2)

• Remove obsolete queue-merging block instruction
• Update README to reflect current merge-queue support · New

[Copilot]

Copilot review overview

🔵 Needs a closer look

Two moderate documentation inconsistencies and several wording corrections remain unresolved.

Review effort: Lite
Findings: 1 · 1

Open (2)

• Remove obsolete queue-merging block instruction
• Update README to reflect current merge-queue support

[Copilot]

Copilot review overview

🟡 Changes recommended

Documentation scope, isolation claims, queue guidance, and task sequencing contain unresolved inconsistencies.

Review effort: Lite
Findings: 1

Open (1)

• Remove stale instruction to keep queue merging disabled · New

Resolved since last review (2)

• Remove obsolete queue-merging block instruction
• Update README to reflect current merge-queue support

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved documentation mismatches remain across README scope, security disclosures, prerequisites, and queue validation.

Review effort: Lite
Findings: None

Resolved since last review (1)

• Remove stale instruction to keep queue merging disabled

Previously missed (1)

In code that hasn't changed since last review

README omits the host-side Ask security limitation

docs/​designs/​codeboost-plan-indexed-review.md:227

This sentence says the README states the host-side Ask exception, but README.md only says that Ask provides read-only answers; it does not disclose that the CLI runs on the host with the user's environment/sign-in. Please update the README to carry this security-relevant limitation, or remove this claim from the plan so the two documents do not disagree.

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved moderate findings document startup checks that the implementation does not currently perform.

Review effort: Lite
Findings: None

[Copilot]

Copilot review overview

🔵 Needs a closer look

Address the documented scope and behavior mismatches before approval.

Review effort: Lite
Findings: None

Previously missed (1)

In code that hasn't changed since last review

Clarify ordinary removal retry versus changed-head fresh review

README.md:34

The queue lifecycle does not always send a removal back to review: for an ordinary removal with the same revision, snapshot, review version, and head, MergeCoordinator marks the attempt retryable after the required refresh and the UI offers retry; only a changed head or an attempt requiring fresh review blocks retry. Please distinguish ordinary removal/retry from the changed-head fresh-review path so this README does not promise a review reset that the implementation does not perform.

[Copilot]

Copilot review overview

🔵 Needs a closer look

The design plan must clarify or implement the dependency checks it currently describes as startup preflight.

Review effort: Lite
Findings: None

Previously missed (1)

In code that hasn't changed since last review

Document actual dependency preflight behavior

docs/​designs/​codeboost-plan-indexed-review.md:648

This new installation requirement says the CLI checks for git, gh, Docker/Podman, and provider credentials, but web/cli.ts only calls requireSupportedNode() before starting the server; the other dependencies are not preflighted. That makes the plan inaccurate for the current code. Either add those startup checks or describe them as feature-time requirements rather than checks performed by codeboost.

[Copilot]

Copilot review overview

🟢 Approval recommended

Documentation-only changes with no blocking issues; remaining comments are minor wording clarifications.

Review effort: Lite
Findings: None