Skip to content

Record selection accessibility review lesson - #15

Merged
mchwang merged 2 commits into
mainfrom
codex/review-accessibility-lesson
Sep 24, 2026
Merged

mchwang merged 2 commits into
mainfrom
codex/review-accessibility-lesson

Conversation

@mchwang

@mchwang mchwang commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

PR #14's automated review caught a reusable accessibility gap: a row could look selected while assistive technology received no selected-state signal. The lesson should have been included before PR #14 merged.

Add two repository rules:

  • Stateful rows and controls must expose visual selection through the appropriate accessibility attribute and test that state across navigation.
  • Review-lesson extraction is an explicit merge gate. Every review finding must be classified in the PR body as covered by an existing cited rule, captured by a new cited rule in the reviewed head, or one-off with a recorded reason. Merge is prohibited until the audit is complete.

Review-lesson audit

Validation: git diff --check passes. CI reruns the repository's typecheck, 188 unit/integration tests, and 38 browser tests on the updated head. Copilot rereview is requested after this update.

Copilot AI lite review requested due to automatic review settings September 23, 2026 23:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The documentation change has no unresolved blocking issues.

Review effort: Lite
Findings: None

What changed in this PR

Adds a repository accessibility guideline for selected-state semantics and navigation testing.

Changes:

  • Documents appropriate aria-current/aria-selected usage.
  • Requires regression coverage across navigation.
File Description
AGENTS.md Adds the selected-state accessibility and testing rule.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI review requested due to automatic review settings September 23, 2026 23:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The documentation-only change has been fully reviewed with no unresolved blocking issues.

Review effort: Lite
Findings: None

@mchwang
mchwang merged commit b11b93f into main Sep 24, 2026
3 checks passed
@mchwang
mchwang deleted the codex/review-accessibility-lesson branch September 24, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants