Record selection accessibility review lesson - #15
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation change has no unresolved blocking issues.
Review effort: Lite
Findings: None
What changed in this PR
Adds a repository accessibility guideline for selected-state semantics and navigation testing.
Changes:
- Documents appropriate
aria-current/aria-selectedusage. - Requires regression coverage across navigation.
| File | Description |
|---|---|
AGENTS.md |
Adds the selected-state accessibility and testing rule. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #14's automated review caught a reusable accessibility gap: a row could look selected while assistive technology received no selected-state signal. The lesson should have been included before PR #14 merged.
Add two repository rules:
Review-lesson audit
Validation:
git diff --checkpasses. CI reruns the repository's typecheck, 188 unit/integration tests, and 38 browser tests on the updated head. Copilot rereview is requested after this update.