Repository navigation
fix(home): draw unselected tab glyphs and labels white on every iOS version - #1073
Merged
Merged
Conversation
…ersion iOS 27 already paints unselected tab glyphs in textMain. iOS 26 drew them in textSecondary, and the legacy pill bar dimmed whole items to 50%. Both now match iOS 27; the profile photo keeps its half-opacity unselected state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unselected tab glyphs and labels were white only on iOS 27, where the system ignores the unselected
iconColor. Earlier versions now match:HomeTabView): unselected icon and title color go fromtextSecondarytotextMain.TabBarBadgedIcon): alwaystextMain, so the version check inglyphColorgoes away.HomeTabBar): the 50% opacity moves off the whole item onto the profile photo only, so glyphs, labels, and the unread bubble stay at full strength.The profile photo keeps its unselected state (thinner ring, half opacity), as before. Android: code-payments/code-android-app#1786.