Repository navigation
chore(chat): log the attach lifecycle the same way in both hosts - #1062
Merged
bmc08gt merged 1 commit intoOct 14, 2026
Merged
Conversation
The overlay logged under flipcash.attach-overlay and the bar path didn't log its open or close at all. Both now log under flipcash.attach: - "Attach opened" with the host and how it was chosen (mode, overlapHeight, inputWindowFound, canReplaceInputView, refused) - "Attach event" when an event takes something down, with the event, host and response - "Attach closed" with the host the surface was opened in The opening line's keyboardHeight and keyboardWindowFound fields are renamed overlapHeight and inputWindowFound: the log redactor blanks any field whose name contains "key".
bmc08gt
added this pull request to stack #1063
October 14, 2026 19:25
bmc08gt
added a commit
that referenced
this pull request
Oct 14, 2026
* commit '16a24ad1eb3eeac2097eac72d32150ba2c368f18': fix(ui): draw UIKit caption in Avenir Medium like SwiftUI (#1064) fix(members): host chip and member count label to match Android (#1058) chore(chat): log the attach lifecycle the same way in both hosts (#1062) refactor(chat): decide attach close events in one place (#1061) refactor(chat): measure the attach card's frame once (#1060) refactor(chat): read the attach menu rows live over the keyboard (#1059) refactor(chat): build the attach actions once for both hosts (#1056) fix(chat): render system messages in the transcript (#1054) # Conflicts: # Flipcash/Core/Screens/Conversation/ChatScreenRepresentable.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The overlay logged under
flipcash.attach-overlay, and the bar path didn't log opening or closing at all, so a log from a keyboard-down session couldn't show what the attach surface did. Both hosts now log underflipcash.attach:Attach opened: the host, and how it was chosen (mode,overlapHeight,inputWindowFound,canReplaceInputView,refused).Attach event: an event that took something down, with the event, the host and the response.Attach closed: the host the surface was opened in.The opening line's
keyboardHeightandkeyboardWindowFoundfields are nowoverlapHeightandinputWindowFound.SensitiveKeyRedactorblanks any field whose name contains "key", so those two have always logged as[REDACTED].Stacked on #1061. #1053's overlay touch log uses the overlay's old file logger, which this removes; whichever merges second switches it to
attachLogger.