Repository navigation
refactor(chat): move photo upload and sealing glue into FlipcashCore - #1039
Merged
Merged
Conversation
ChatMediaUploader, its blob-store seam, UploadedPhoto, the upload error classification, the plaintext/sealed send guard, ImageIO decode, the BlurHash encoder and display-name resolution now live in FlipcashCore so a share extension can link them without FlipcashUI. Upload progress is reported through ChatPhotoUploadProgress, which ChatPhotoSendProgress conforms to, and the contact-name lookup is injected into Conversation.displayName. The app keeps SessionChatMediaBlobStore and a UIImage overload of the uploader.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the photo upload and sealing code a share extension needs out of the app target and into FlipcashCore. No behaviour change; the share extension PR stacked on this one links it.
Moved:
ChatMediaUploaderand its blob-store seam,UploadedPhoto, the upload error classification, the plaintext/sealed send guard, the ImageIO decode, the BlurHash encoder, and display-name resolution.Two seams replace app types the extension can't link:
ChatPhotoUploadProgressprotocol, whichChatPhotoSendProgressconforms to.Conversation.displayNametakes the contact-name lookup as a parameter instead of reaching into Contacts.The app keeps
SessionChatMediaBlobStoreand aUIImageoverload of the uploader.