Repository navigation
fix(tip): raise a DM fee floor to the regional minimum - #1754
Merged
Merged
Conversation
Re-lands #1599, which merged into fix/tip-floor-rounding after #1597 had already merged that branch into code/cash, so it never shipped. startChattingFee returns the recipient's converted fee even when it is under minTipAmount. Every tip carries the regional minimum, so a fee like 1000 NGN (about $0.76) states a floor the server always denies with "tip amount is below the minimum of 1 USD". A fee under the minimum now falls back to it. The function was renamed from minimumToOpenDmWith since #1599; the change is otherwise the same.
github-actions
Bot
added
area: payments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-lands #1599. It targeted
fix/tip-floor-roundingand merged at 18:35 UTC on Sep 28, a minute after #1597 had merged that branch intocode/cash, so its commit never reachedcode/cash.startChattingFeereturns the recipient's converted fee even when it's underminTipAmount. Every tip carries the regional minimum, so a fee like 1000 NGN (about $0.76) states a floor the server always denies with "tip amount is below the minimum of 1 USD". A fee under the minimum now falls back to it. The minimum is in the entry currency or is the USD fallback row, andisBelowcompares the fee in whichever it is. A fee with no USD rate keeps its own floor and the server stays the authority.The function was
minimumToOpenDmWithwhen #1599 was written; the logic and its two tests are unchanged apart from the name. Both tests fail against currentcode/cash.The iOS change is code-payments/code-ios-app#891.