fix(txn-details): drop the token badge from the header avatar - #1435
Merged
Conversation
The details header drew the mint as a coin over the avatar's bottom-right
corner, the same badge the activity row uses. On this screen it is redundant:
the line under the amount already names the token ("Aug 29 • Jeffy"), so the
badge repeats it. Figma 9708:117414 draws the header avatar bare — an 80x80
circle with no coin.
The row keeps the badge, where it is the only thing naming the token; without
it every tip reads the same whether it was dollars or a creator coin.
TransactionAvatarImage is shared between the two, so this adds showBadge rather
than changing the model. The slot collapses to the avatar's own size when the
badge is off, since there is then nothing to overhang — which also drops the
10dp of dead space the header was carrying above the name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Transaction Details header drew the mint as a small coin badged over the avatar's bottom-right corner — the same badge the activity row uses. On this screen it says nothing new: the line directly under the amount already names the token ("Aug 29 • Jeffy"). Figma
9708:117414draws the header avatar bare, an 80×80 circle with no coin.The activity row keeps its badge. There the badge is the only thing naming the token, and
TransactionAvatar's own docs give the reason — without it every tip reads the same whether it was dollars or a creator coin.TransactionAvatarImageis shared between the row and the details screen it opens, so this adds ashowBadgeparameter rather than changingTransactionAvatar.badgeToken, which the row still needs. With the badge off the slot collapses to the avatar's own size, since there is nothing left to overhang; that also removes the 10dp of dead space the header was carrying between the avatar and the name.Convert entries are unaffected — their overlapping token pair is the avatar itself, not a badge.