Fix invalid speed measurements and bound test runs - #304
Merged
Merged
Conversation
code-inflation
force-pushed
the
fix/p1-measurement-correctness
branch
from
September 13, 2026 07:42
55b6a2f to
2d5235f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three ways the speed test could report wrong results: truncated/timed-out
downloads counted as full transfers, HTTP errors used as latency samples, and
empty runs exiting 0. Runs are now bounded (120 s deadline, 30 s retry budget)
and report complete/partial/failed with proper exit codes; Ctrl-C keeps
completed samples. Quartiles were also fixed for odd sample counts.
New flags:
--max-duration,--max-retry-wait,--server. CSV and existingJSON fields are unchanged; JSON adds run status and errors. Library: missing
latency is NaN instead of 0,
fetch_metadatareturnsMeasurementError.