Repository navigation
ci: first-run fixes and temporary test-repository default - #2
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the installer tests and Windows installer script to better match current CLI behavior and to address first-run/tooling issues, while also changing the default download repository to a temporary test repository.
Changes:
- Tests: expand the restricted-PATH command set and update
--versionassertions to match the current CLI output format. - Shell installer: change
DEFAULT_REPOSITORY(currently to a test repo). - PowerShell installer: rename
Test-ZipEntries→Test-ZipArchiveand inline directory creation calls.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/install.bats |
Adds gzip/gunzip/cat to restricted PATH stubs; updates CLI --version assertions to match real output. |
install.sh |
Changes the default repository used to construct download URLs. |
install.ps1 |
Updates default repository; renames the zip-validation function and inlines directory creation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- PSScriptAnalyzer: rename Test-ZipEntries to Test-ZipArchive, inline the directory-creation helper - tests: add gzip/gunzip/cat to the restricted-PATH wget stubs; update remaining --version assertions to the real CLI output format - default repository temporarily points at the test repo (TODO reverts before release) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single squashed commit:
Test-ZipEntries→Test-ZipArchive, inline the directory-creation helpergzip/gunzip/catto the restricted-PATH wget stubs; update remaining--versionassertions to the real CLI output formatVerified locally: end-to-end install of the real 1.19.2 binary from the test repo, ShellCheck/PSScriptAnalyzer-parse clean.
🤖 Generated with Claude Code