feat: upgrade Cloudinary video player from v1 to v4 - #665
eportis-cloudinary wants to merge 2 commits into
Conversation
Requires @cloudinary-util/url-loader@6.3.2, which stops deriving aspectRatio from width/height — player v4 renders that as an invalid poster URL (cloudinary/cloudinary-video-player#1087). BREAKING CHANGE: the video player's default appearance changes.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I tested this locally by running player v1.11.1 ( Explicit If a user sets I tested a fix, based on tsi's reply on cloudinary-video-player#1087: pass the transformation as a single object instead of an array (unless the user passed an array themselves). With that change, the posters load and every other scenario behaves the same. The one downside is that poster URLs change for everyone, and video URLs change for users with a transformation object. The output is identical, but Cloudinary will generate those assets again once. I think this belongs in url-loader's Until then, users can also set Pre-existing issue: broken icon files
Issues checked while testing the url-loader upgrade
None of this blocks the pull request. Approving, and it looks good to merge. |
PaulBoye-py
left a comment
There was a problem hiding this comment.
Approving. See my testing notes in the comment above.
Requires @cloudinary-util/url-loader@6.3.2, which stops deriving aspectRatio from width/height — player v4 renders that as an invalid poster URL (cloudinary/cloudinary-video-player#1087).
BREAKING CHANGE: the video player's default appearance changes.