fix: preserve falsy values, stable keys, crash guard, and class typo … - #661
Merged
Merged
Conversation
…in Table component - Replace || fallback with null/undefined check to preserve falsy values like 0 - Add default props (columns=[], data=[]) and guard columns usage in tbody to prevent runtime crash - Fix Tailwind class typo last pr-0 -> last:pr-0 - Use stable row keys (row.id ?? rowIndex) instead of array index Fixes #614.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
eportis-cloudinary
added a commit
that referenced
this pull request
Sep 25, 2026
Brings 146 commits from main onto the v7 branch, including Next.js 16 compatibility (#657), the Node 20/22 CI matrix (#656), the Trusted Publishers release plumbing, and three recent fixes: duplicate iframes on CldUploadWidget unmount (#658), open() called before the widget script loads (#659), and the docs Table component (#661). Conflicts resolved as follows: - CldVideoPlayer.tsx: union. Kept beta's 'use client' and named-only react import, added main's useState, which the merged body needs for isScriptLoaded/playerInitialized. - next-cloudinary/package.json: kept beta's preconstruct build config, exports map, files and 7.0.0-beta.11 version; adopted the repository field main added in 554e2a0. - package.json: kept @preconstruct/cli (beta's build needs it); dropped @colbyfayock/semantic-release-pnpm, which the merged .releaserc no longer references; took main's semantic-release 25 and @semantic-release/npm 13. - pnpm-workspace.yaml: beta's list, which adds the test app - required because beta's test:app builds it via pnpm rather than npm install. - tests/nextjs-app/package.json: main's Next 16 / React 19 versions plus beta's next-cloudinary workspace link. - CHANGELOG.md: kept both release histories. - pnpm-lock.yaml: regenerated against the merged manifests. Also fixes CldUploadWidget.tsx, which git auto-merged without conflicting but produced broken output: beta had dropped the default React import while main's useUploadWidgetId helper calls React.useId and React.useRef. The combination built fine and failed at prerender with "ReferenceError: React is not defined". Restored the default import. Caught by test:app, not by the unit tests. Note: .releaserc auto-merged to main's @semantic-release/npm, which drops beta's publishBranch "main|beta" setting. Branch gating now comes from the top-level branches config alone.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes multiple bugs in
docs/components/Table/Table.js:row[id] || ' 'replaced falsy values like0,false, and""with a space. Changed to an explicitnull/undefinedcheck so valid falsy values display correctly.tbodyrendered whendataexisted but calledcolumns.map()without checking ifcolumnswas defined. Added a guard and default props (columns = [],data = []) to prevent the crash.last pr-0→last:pr-0(missing colon meant the class never applied).index, causing rendering issues on reorder/update. Changed torow.id ?? rowIndexfor stable keys.Issue Ticket Number
Fixes #614
Type of change
Checklist