Repository navigation
impr: CPO-1752 move to CDK and Node 24.x - #153
Merged
Merged
Conversation
trend-adam-kinnell
approved these changes
May 1, 2026
trend-adam-kinnell
left a comment
trend-adam-kinnell
left a comment
Contributor
There was a problem hiding this comment.
LGTM ✅
Just some comments, but nothing blocking the release now considering the deadline.
| "lint": "eslint '**/*.js' --ignore-path .gitignore", | ||
| "lint:fix": "npm run lint -- --fix", | ||
| "sls:deploy": "npm prune --production && serverless deploy --force" | ||
| "sls:deploy": "npm prune --production && serverless deploy --force", |
Contributor
There was a problem hiding this comment.
🏕️ Let's remove sls:deploy
Contributor
There was a problem hiding this comment.
♻️ Could we split this into individual files per lambda to reduce the number of lines in this file?
Contributor
Author
There was a problem hiding this comment.
we could split them, but that requires making custom constructs and we were told to try and keep to l1 and l2 constructs for initial changes
It would definitely be something to do in the future though 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link:
CPO-1752
What does it do?
Checklist
feat: XX-1234 ...)feat: XX-1234 ...)Notes to reviewers
(eg. Majority of LOC changes were prettier. Specific file to look at is package.json)
Screenshots
(eg. A picture is worth 1000 words...)
Related PR's
(eg. cloudconformity/.github#1)