Skip to content

UNBREAKING CHANGE: remove jfrog from package-lock.json - #151

Merged
Shreda merged 1 commit into
mainfrom
rm_artifactory
Aug 29, 2025
Merged

Shreda merged 1 commit into
mainfrom
rm_artifactory

Conversation

@Shreda

@Shreda Shreda commented Aug 29, 2025

Copy link
Copy Markdown
Contributor

Issue Link:

auto-remediate is currently broken as it tries to download dependencies from internal artifactory.

What does it do?

  • package-lock.json currently references internal jfrog endpoints which our customers do not have access to. This means customers cannot run npm install as they will get a 401 error.
  • This PR does a find and replace to put back the correct registry, npm install has been run to validate the integrity and reach-ability of the packages.

Checklist

  • BREAKING CHANGE - I have/intend to update all places where this package is used.
  • I will squash: PR title conforms to standard commit message format (feat: XX-1234 ...)
  • I will merge without squashing: All commits conforms to standard commit message format (feat: XX-1234 ...)
  • README update

Notes to reviewers

(eg. Majority of LOC changes were prettier. Specific file to look at is package.json)

Screenshots

(eg. A picture is worth 1000 words...)

Related PR's

(eg. cloudconformity/.github#1)

@jay-motwani-trend jay-motwani-trend left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Shreda
Shreda merged commit 676b62e into main Aug 29, 2025
5 checks passed
@Shreda
Shreda deleted the rm_artifactory branch August 29, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants