Repository navigation
UNBREAKING CHANGE: remove jfrog from package-lock.json - #151
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link:
auto-remediate is currently broken as it tries to download dependencies from internal artifactory.
What does it do?
package-lock.jsoncurrently references internal jfrog endpoints which our customers do not have access to. This means customers cannot runnpm installas they will get a 401 error.Checklist
feat: XX-1234 ...)feat: XX-1234 ...)Notes to reviewers
(eg. Majority of LOC changes were prettier. Specific file to look at is package.json)
Screenshots
(eg. A picture is worth 1000 words...)
Related PR's
(eg. cloudconformity/.github#1)