Conversation
| "time" | ||
|
|
||
| espressoClient "github.com/EspressoSystems/espresso-network/sdks/go/client" | ||
| sdkclient "github.com/EspressoSystems/espresso-network/sdks/go/client" |
| return block.Hash(), nil | ||
| } | ||
|
|
||
| // networkTimeoutCtx bounds a single external call with the configured network |
Collaborator
There was a problem hiding this comment.
Can we keep that comment?
| channelMgr: state, | ||
| degradedLog: oplog.NewRepeatStateLogger(), | ||
| } | ||
| if batcher.Espresso.Client != nil { |
Collaborator
There was a problem hiding this comment.
Suggestion: introduce a startEspressoStreamer() function similar to stopEspressoStreamer().
philippecamacho
approved these changes
Sep 29, 2026
philippecamacho
left a comment
philippecamacho
left a comment
Collaborator
There was a problem hiding this comment.
Some minor suggestions. LGTM. (PLEASE DO NOT MERGE before cLabs approval.)
jjeangal
approved these changes
Sep 29, 2026
jjeangal
left a comment
jjeangal
left a comment
Collaborator
There was a problem hiding this comment.
Minor comment. I do not have much to say that hasn't been said.
| type EspressoTransactionSubmitterConfig struct { | ||
| Ctx context.Context | ||
| EspressoClient espressoClient.EspressoClient | ||
| EspressoClient espressoSubmissionClient |
Collaborator
There was a problem hiding this comment.
Can we also rename EspressoClient to EspressoSubmissionClient?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description