Conversation
…o Sepolia combiners Point the ContractKit setup prose at Celo Sepolia too. Refs #2290 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No v3 deployment is published for Celo Sepolia; point testers at v4. Refs #2290 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… examples Refs #2290 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The service is gone from celo-monorepo. Redirect the page and its old paths to the release process overview. Refs #2290 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GigaHierz
left a comment
There was a problem hiding this comment.
head d306f47 · Check for broken links pass (CI) · ODIS URLs and keys rechecked against social-connect source · @celo/identity 5.1.2 and 6.0.0-beta.0 inspected from npm · Uniswap v3 addresses checked with eth_getCode on both networks · no e2e (docs only)
REQUEST-CHANGES. Three findings, all small; one is a live example the sweep missed.
Findings
-
Medium ·
home/protocol/transactions/transaction-types.mdx:309,331,335. The viem example still importsceloAlfajoresfromviem/chainsand uses it for both clients (chain: celoAlfajores, // Celo testnet). This is a live instruction, not history, and it is the same class as the six pages this PR fixes (#2290). A reader who copies it points at the retired network.
Fix: import and useceloSepolia(it exists inviem/chains; I checked the current package) and change the comment to "Celo Sepolia testnet". -
Low ·
tooling/libraries-sdks/portal/index.mdx(fiveeip155:examples). The swap toeip155:11142220is unverified, as the PR body says. Portal's own chain list names Celo mainnet (eip155:42220) and Alfajores (eip155:44787) and does not mention Celo Sepolia. The old value was already dead, so this is not worse than before, but the page now states a chain ID Portal does not document.
Fix: either confirm with Portal that Celo Sepolia is supported and note it here, or add one line under the first example: "Portal's chain list does not yet name Celo Sepolia; confirm support with Portal before relying on it." -
Low ·
tooling/contracts/uniswap-contracts.mdx:3. The frontmatterdescriptionstill reads "Uniswap v4 and v3 contract addresses on Celo Mainnet and the Celo Sepolia Testnet". After this PR v3 is mainnet only, and the description is whatllms.txtand search show.
Fix: "Uniswap v4 contract addresses on Celo Mainnet and Celo Sepolia, and v3 addresses on Celo Mainnet".
Verified good
- ODIS endpoints: both new URLs return 200 on
/status; the oldcloudfunctions.netmainnet URL returns 404. - ODIS keys and URLs: they match
ODIS_MAINNET_CONTEXT_PNPandODIS_CELO_SEPOLIA_CONTEXT_PNPinsocial-connectpackages/identity/src/odis/query.ts, character for character. The PR uses the PNP keys, which is right for this phone-number page. - Version claims:
@celo/identity6.0.0-beta.0 shipsgetServiceContext,OdisContextName.CELO_SEPOLIAand the Celo Sepolia contexts. 5.1.2 hasgetServiceContextbut no Celo Sepolia context, so "5.1.2 has no Celo Sepolia context" is correct. - Uniswap v3: the mainnet factory,
SwapRouter02andUniversalRouterhave code on Celo mainnet and0xon Celo Sepolia, so "no published Celo Sepolia deployment" holds for those addresses. - Deleted page:
attestation-servicehas a redirect; the two older redirects that landed on it now go straight to/contribute-to-celo/release-process; no other inbound references remain, and the nav entry and overview link are gone. No redirect chains. setup.mdx: the code already used the Sepolia RPC, so the prose now matches it.- Remaining Alfajores mentions: I read all of them on this head. Apart from finding 1, they are history, notices or migration pages.
What the PR got right
Honest scoping: the caveats section names exactly the two things it could not verify. Replacing the dead ODIS table with values from the published source is the right fix, not just a rename. Deleting a runbook for a retired service, with redirects, is better than renaming networks inside it. This is one round of three targeted edits.
Merge-order hazards
docs.json redirects and nav are touched, so any PR editing those lines near release-process may need a rebase. #2353 adds redirects near the top of the list, so expect a trivial conflict if both are open. No other open PR touches these pages.
Switch the transaction-types viem example to celoSepolia, flag that Portal's chain list does not yet name Celo Sepolia, and scope the Uniswap page description to v3 on mainnet only.
42793e5 to
c927d24
Compare
|
All three are fixed in c927d24.
|
Five pages still told readers to use Alfajores, which is retired, and the ODIS page's endpoint table was dead for mainnet too: every
cloudfunctions.netURL on it returns 404. This moves the live instructions to Celo Sepolia and removes the release runbook for the attestation service, which no longer exists; the deletion and its redirects follow the pattern #2293 used for orphaned pages. Pages that mention Alfajores as history stay as they are. Closes #2290.What changed
tooling/libraries-sdks/contractkit/odis.mdxsocial-connectpackages/identity/src/odis/query.tsand match the published@celo/identity@6.0.0-beta.0. Adds thegetServiceContext(OdisContextName.CELO_SEPOLIA)snippet for 6.0.0-beta.0+, and says 5.1.2 needs the values passed in by hand.tooling/libraries-sdks/contractkit/setup.mdxtooling/contracts/uniswap-contracts.mdx<Info>box, which claimed v3 was on Celo Sepolia.tooling/libraries-sdks/portal/index.mdxeip155:44787→eip155:11142220in the gateway config and the fourreceiveTestnetAssetexamples.contribute-to-celo/release-process/attestation-service.mdx/contribute-to-celo/release-process, and the two older redirects that landed on it now go there directly. The nav entry and the link on the overview page are gone.migrating-to-viem.mdx, listed in the issue, was already clean onmain.Caveats
eip155:11142220works for the gateway or forreceiveTestnetAsset. If it does not, the faucet link already on the page still works.eth_getCodereturns0x), and Uniswap's v3 Celo deployment page has only CELO and Alfajores columns. The page now says v3 has no published Celo Sepolia deployment and points testers at v4. If a deployment exists somewhere, the column can come back with checked addresses.GET /statuswith{"version":"3.3.3"}. I did not run an identifier lookup, which needs an account with ODIS quota.contractKittoWalletKeySigner, which is the 5.x API. The pending@celo/identity6.0.0 release switches that tosign191, so the page needs another pass when 6.0.0 ships.Verification
rg -nil 'alfajores|44787' --glob '*.mdx' .returns only the 14 pages the issue lists as out of scope.mint broken-links: no broken links found.mint dev: all three attestation-service paths return 307 to/contribute-to-celo/release-process, and the five edited pages return 200.🤖 Generated with Claude Code