Skip to content

fix(ci): publish container image after CI passes on main - #747

Merged
Ferryx349 merged 1 commit into
mainfrom
fix/publish-image-push-trigger
Aug 30, 2026
Merged

fix(ci): publish container image after CI passes on main#747
Ferryx349 merged 1 commit into
mainfrom
fix/publish-image-push-trigger

Conversation

@Ferryx349

@Ferryx349 Ferryx349 commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR fixes container image publishing after the Cycode security finding on workflow_run.

  • Removes standalone publish-container-image.yml (unsafe workflow_run trigger)
  • Adds publish-container-image as the final job in checks.yml on push to main
  • Uses always() gating: if source changed, lint/build/tests must pass; if not, publish still runs after post-tests
  • Adds workflow unit test and CI docs (docs/DEPLOYMENT.md, docs/CI-MIGRATION.md)
  • Updates deploy/README.md link to point at the new CI docs

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • I added a changeset, or this is docs-only and I added an empty changeset.
  • All new and existing tests passed.

@changeset-bot

changeset-bot Bot commented Aug 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f2d33fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nostream Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls

coveralls commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

Coverage Status

Coverage is 71.326%fix/publish-image-push-trigger into main. No base build found for main.

@Ferryx349 Ferryx349 changed the title fix(ci): replace workflow_run with push trigger for image publish fix(ci): publish container image after CI passes on main Aug 29, 2026
Move publish into checks.yml with always() gating, add workflow test and CI docs, and fix deploy README link.
@Ferryx349
Ferryx349 force-pushed the fix/publish-image-push-trigger branch from 4877413 to f2d33fa Compare August 30, 2026 15:00
@Ferryx349
Ferryx349 merged commit 14cca60 into main Aug 30, 2026
22 checks passed
@Ferryx349
Ferryx349 deleted the fix/publish-image-push-trigger branch August 30, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants