Repository navigation
Conversation
…not free the simlock lease
…ndedLeases 1 failing -> 0 failing
…; document endedLeases
…etitle the release-after-close test
Contributor
Author
Review notesNot blocking, not verified. Each is one reviewer's claim.
Written by an agent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #607
Status
Implement: done (edge.test.ts 213 passed) Review: round 2 passed Hardware: pass for the iOS close (3 lane runs); other lane failures are #609 and a CoreSimulator crash Gate: not run
Next: gate
Done when
endedLeasesfromdata,error.detailsand abatch'sdata, and releases the simlock lease it holds for this token (marked ended by the agent). Checked by the threeendedLeasescases insrc/agent-device/edge.test.ts, plus a streamed-reply case added in review. On the slow lane, "close releases the simlock lease before the CLI exits, and a following open works" passed in all three runs on 40ca176.pnpm exec vitest run --project unit src/agent-device/edge.test.ts -t endedLeasespasses. Checked by the green and fix runs and CI.Assumptions
error.details— the fake and the JSON-RPC error carry it aserror.data.details, so only that form is read; a bareerror.detailsis untested and was dropped.Review
Spec review: 0 blocking, 0 fixed, 1 notes. Code review: 1 blocking, 1 fixed, 0 notes. Claims review: 1 blocking, 1 fixed, 0 notes.
Rounds: 2. Tokens: 16.2M.
Written by an agent.