Repository navigation
Merged
Conversation
Contributor
Author
Review notesNot blocking, not verified. Each is one reviewer's claim.
Written by an agent. |
V3RON
marked this pull request as ready for review
October 15, 2026 12:32
V3RON
added this pull request to stack #600
October 15, 2026 12:32
V3RON
force-pushed
the
task/595
branch
2 times, most recently
from
October 15, 2026 13:45
2d691b7 to
529ad68
Compare
…capabilities (#595) why: the host, the capabilities config namespace, core route names, the dependency rules and protocol 38 turn the spec tests green; Config fixtures gain capabilities: {}. Failing: most -> 1 failing (the 'busy' capability state in optional-modules.test.ts is not a state status.get accepts)
why: the contract now requires capabilities. 4 failing -> 2 failing
…ry manuals (#595) why: the change makes the config, HTTP and architecture docs incomplete. 2 failing -> 1 failing
why: main.ts now builds the host.
why: Fallow flags unused re-exports.
why: the manuals test. 2 failing -> 1 failing (plus the busy-state spec test)
1 failing -> 0 failing
…sts prove their claims, readiness order in the daemon manual (#595)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #595
Status
Implement: done (5303/5303 green) Review: round 2 passed, 1 text fix applied unreviewed Hardware: deferred to the end of the run Gate: waiting for the stack
Next: hardware check at the end of the run, then the stack gate
Done when
pnpm test:changed: 5303 passed).pnpm lintpasses (commit hook: lint, boundaries, typecheck, fallow green) with the dependency-cruiser changes above.simlock config geton a fresh worker prints"capabilities": {}.main.tsimports nothing fromsrc/modulesbutcreateModuleHostand types, and nothing fromsrc/module-registrybutoptionalModules.Assumptions
Assumption: the ordering claims "after agent-device's stop steps" (
beforeDrain,beforeDriversDispose) and "after agent-device's" (doctor findings) have no cheap seam, so those tests prove the other half of each claim and their titles say only that — the green stage or the audit should check the agent-device ordering by hand.Assumption:
createModuleHostalso takes the daemonlogger(spec lists{ role, definitions, config, context, wiredElsewhere }) — it logs hook failures and builds each module's child logger.Assumption: the by-shape copies are named
Module*insrc/modules(ModuleCapabilitySource,ModuleRelayTarget,ModuleEndedLease,ModuleLeaseEndParticipant,ModuleDispatch,ModuleMount).Assumption: a module's
checkruns only on a worker — a gateway ignores worker keys, so checking them would fail a start over a value nothing reads.Assumption: a module whose
findings()keeps throwing is warned once, when it starts to — doctor reads findings at startup and at every run.Assumption: the fake module's default capability state is
available(the oldreadyis not a statestatus.getaccepts).Assumption: the spec test "a module turned on is loaded once..." used state
busy, whichstatus.getdoes not accept (only available, unavailable, off); the fixture value is nowunavailable(round 1 asked for a state other than the fake's default), nothing else in the test changed.Review
Spec review: 5 blocking, 5 fixed, 1 notes. Code review: 6 blocking, 6 fixed, 2 notes. Claims review: 1 blocking, 1 fixed, 3 notes.
Rounds: 2. Tokens: 5.4M.
Fixed unreviewed: code: src/modules/host.ts:173 a module whose findings() throws, recovers and throws again is now tested to be warned again.
Rejected:
checkon gateways, not conservative — not blocking: skipping avoids failing a start over values a gateway ignores; spec and docs do not require itWritten by an agent.