agent-device front ignores endedLeases, so close no longer frees the device #607

Activity

1. V3RON

   added

   bug:newReported. Nobody has looked yet.Reported. Nobody has looked yet.

   bug:triageAn agent may reproduce it and write the triage report.An agent may reproduce it and write the triage report.

   and removed

   bug:newReported. Nobody has looked yet.Reported. Nobody has looked yet.

   on Oct 15, 2026
2. V3RON

   self-assigned this

   on Oct 15, 2026
3. V3RON commented on Oct 15, 2026

   

   V3RON

   on Oct 15, 2026

   ContributorAuthor

   More actions

   Reproduction

   Defect, confirmed as reported. On bug/607-repro, src/agent-device/edge.test.ts, a table of three cases: "%s: a command that ends the agent-device lease and names it in endedLeases releases the simlock lease and frees the device though the CLI sends no release, and a later heartbeat answers LEASE_NOT_FOUND". The cases are close (in data), a failed close (in error.details), and a batch with a close step (beside results). FakeAgentDevice now does what 0.21.28 does: it ends the lease on close and reports it.

   pnpm exec vitest run --project unit src/agent-device/edge.test.ts -t endedLeases
   
   × all 3 cases
   AssertionError: expected [ '00000000000000000000000000000001' ] to deeply equal []
    ❯ src/agent-device/edge.test.ts:1256   await expect.poll(async () => listed(rig)).toEqual([]);
   

   The other 209 tests in that file and the gateway, lease-end and main tests still pass with the changed fake.

   Root cause

   src/agent-device/front/front.ts:150 sends every command through runCommand, which hands back agent-device's reply unread (:169). The only code that frees the simlock lease when the agent ends a lease is release.ts:24, and it runs only on an explicit lease.release RPC. agent-device 0.21.28 no longer sends that RPC after close; it reports the end in endedLeases instead (its client-types.d.ts, EndedLease). So the lease stays until its TTL runs out. docs/HTTP-API.md:1580 promises that close frees it.

   Simplest fix

   Move release.ts:17-28 (map entry check, releaseSimlock, mark ended by agent, cancel renewals) into one function. In runCommand, read the reply and collect endedLeases from result.data and from error.data.details. Call that function for each id the map holds for this token. Gateway and worker share this front, so both paths are covered.

   Alternatives rejected

   • Read it in the host's recordingFetch: the host has no front map, and a gateway's map would stay live.
   • Ask agent-device to send lease_release again: chore(agent-device): require agent-device 0.21.28 and take its proxy from npm #603 adopted 0.21.28 on purpose.
   • Rely on the TTL: that is the bug, a 300 s hold.

   Risk

   • A streamed (ndjson) reply has its result in the last frame. Reading it must not hold back the stream (untilBodyEnds).
   • endedLeases is wire input. Act only on leases the map holds for this token.
   • The release scope stays recorded, so lease-end sends agent-device a second release. Check that it answers released: false and does not delay the reclaim, or drop the scope.

   Written by an agent.
4. V3RON

   removed their assignment

   on Oct 15, 2026
5. V3RON

   added

   bug:readyAn agent may fix it.An agent may fix it.

   and removed

   bug:triageAn agent may reproduce it and write the triage report.An agent may reproduce it and write the triage report.

   on Oct 15, 2026
6. V3RON

   self-assigned this

   on Oct 15, 2026
7. V3RON

   closed this as completedin #608on Oct 15, 2026
8. V3RON

   removed their assignment

   on Oct 15, 2026