Repository navigation
feat(network-activity-plugin): migrate the panel to @rozenite/ui - #555
Merged
Merged
Conversation
…f clipping the last tab
…n view while scrolling
…rst to the dev host fixtures
…he Timing fix properly
…r where tabs are cut off
…st and keep it readable
…ab in view Reveal the selected tab once the bar has its width and when selection changes. Keep the bar hairline out of the fade, and give Domain room for a typical host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Network Activity DevTools panel moves from its own shadcn/Radix component copies and local theme to
@rozenite/ui. It now follows the DevTools light and dark themes instead of always rendering dark, and every feature is kept.Panel
PluginShelland a resizableSplitfor the list and side panel. The list stays mounted, so sort, scroll and widths survive opening and closing a request.VirtualizedDataTable.Tabs(the tab bar scrolls and fades its edges when tabs are cut off),DescriptionList, andDataTablefor WebSocket and SSE messages with sticky headers.Menufor "copy as cURL / fetch", plusToolbar,SearchField,BadgeandButton.globals.cssis now@import '@rozenite/ui/styles.css';plus the selected-row styling.class-variance-authority,clsx,tailwind-mergeandtw-animate-css.@rozenite/uiis now a dependency.Fixes
Dev host:
rozenite.config.tsnow replays the device protocol with 26 requests. They cover fetch, XHR, WebSocket, SSE and images; status codes from 2xx to 5xx; failed, pending and loading requests; JSON, XML, HTML, SVG, PNG, PDF and too-large bodies; cookies, initiators and multipart. There's also an opt-in 600-request burst. The panel can be developed and checked in the browser withpnpm --filter @rozenite/network-activity-plugin dev.Related Issue
Closes #553
Context
react-json-tree, because@rozenite/ui'sJsonInspectorhas no per-node copy.@floating-ui/reactfor the filters popup, because@rozenite/uihas no Popover. The popup renders inline, so it keeps the theme.Testing
git fetch origin main && pnpm checks:affected && pnpm test:affected: passed. The plugin has 241 tests; no existing test changed.pnpm release:planand a forced plugin build: passed.Browser checks: the panel ran in the in-browser dev host against the replayed device traffic, driven with Playwright in Chrome, dark and light, at 1440, 900, 600 and 480 px. All 33 states were captured before and after, plus scripted checks of:
The console has no panel errors.
Review: an independent adversarial review ran four times; every finding is fixed.
Not yet verified in React Native DevTools on a device. Steps to check:
docs/agents/playground-testing.md,rozenite://network).