Repository navigation
test: make shared fixture shutdown checks independent of order - #1303
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Memory as the first shared fixture made the Skills and Subagents configuration tests fail on main: both assumed Subagents had to be the first shutdown operand. Check that each selected fixture participates in the guard and awaited
.close()chain regardless of position, while preserving the closed fixture selection checks.Validation: all 10 Deep Agents configuration checks passed; 12 mutation probes still reject missing guards, operands, awaits, and closes. Both affected Nx fixture targets passed, followed by 9 Skills and 13 Subagents browser cases. Runtime and server code are unchanged.