Repository navigation
test(website): synchronize announcement test lifecycle - #1298
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
blove
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Announcement timing tests could advance the shared browser clock before a native example finished configuration, expiring its bootstrap deadline and leaving the textbox absent. Wait for the native textbox to attach before advancing announcement eligibility. Preserve intentional deployed-preview skips in teardown while retaining the exact forbidden-request assertion for every executed or initialized case.
Validation: exact-head CI and CodeQL passed. The local Website suite passed 339 cases with four intended skips; deployed preview passed 299 cases with 32 intended skips. Neither suite reported flaky retries. The production-copy check passed 11 cases and scroll harness passed 10. A controlled two-second Angular startup delay reproduced the original failure and passed after synchronization; the teardown regression changed from 11 failures to 11 clean skips, and seven callback checks confirmed executed-case guards remain strict.