Repository navigation
fix(website): keep announcements clear of active Run controls - #1297
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Active Run mode can show a timed announcement over native example controls. Hide the announcement while the website workspace is actually in Run mode, and restore ordinary eligibility when navigating back to Docs, Code, or API.
Adds Angular and React desktop/mobile coverage for timer and scroll eligibility, native draft interaction, history, iframe identity, focus/accessibility, dismissal, and mobile modal composition. The marketing case observes real timer registration before advancing the clock and waits for actual scroll depth and mounting.
Validation: 11 focused browser cases pass against production; the marketing case passes against development; focused TypeScript check and lint pass. Website unit suite: 1,697 passing. Production build passes. Fresh PR CI is required before merge.