Skip to content

cranelift-object: set symbol flags after defining #14519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcrichton merged 1 commit into from
Oct 4, 2026
+15 −15
Merged

cranelift-object: set symbol flags after defining #14519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions cranelift/object/src/backend.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,21 +592,6 @@ impl Module for ObjectModule {
section
};

if used {
match self.object.format() {
object::BinaryFormat::Elf => match self.object.section_flags_mut(section) {
SectionFlags::Elf { sh_flags, .. } => *sh_flags |= elf::SHF_GNU_RETAIN,
_ => unreachable!(),
},
object::BinaryFormat::Coff => {}
object::BinaryFormat::MachO => match self.object.symbol_flags_mut(symbol) {
SymbolFlags::MachO { n_desc, .. } => *n_desc |= macho::N_NO_DEAD_STRIP,
_ => unreachable!(),
},
_ => unreachable!(),
}
}

let align = std::cmp::max(align.unwrap_or(1), self.isa.symbol_alignment());
let offset = match *init {
Init::Uninitialized => {
Expand All @@ -626,6 +611,21 @@ impl Module for ObjectModule {
relocs,
});
}

if used {
match self.object.format() {
object::BinaryFormat::Elf => match self.object.section_flags_mut(section) {
SectionFlags::Elf { sh_flags, .. } => *sh_flags |= elf::SHF_GNU_RETAIN,
_ => unreachable!(),
},
object::BinaryFormat::Coff => {}
object::BinaryFormat::MachO => match self.object.symbol_flags_mut(symbol) {
SymbolFlags::MachO { n_desc, .. } => *n_desc |= macho::N_NO_DEAD_STRIP,
_ => unreachable!(),
},
_ => unreachable!(),
}
}
Ok(())
}
}
Expand Down
Loading