Conversation
bybatkhuu
added
bug
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Updates CI and development tooling to Python 3.11, adds Python 3.14 metadata, and centralizes Loguru type definitions.
Changes:
- Updates workflows, pre-commit, and local Python versions to 3.11.
- Adds the Python 3.14 classifier.
- Refactors shared
RecordandMessagetype annotations.
File summaries
| File | Description |
|---|---|
src/beans_logging/sinks.py |
Uses shared Message type. |
src/beans_logging/schemas.py |
Centralizes callable type aliases. |
src/beans_logging/rotators.py |
Uses shared Message type. |
src/beans_logging/formats.py |
Uses shared Record type. |
src/beans_logging/filters.py |
Uses shared Record type. |
pyproject.toml |
Adds Python 3.14 classifier. |
.python-version |
Sets local Python to 3.11. |
.pre-commit-config.yaml |
Configures pre-commit for Python 3.11. |
.github/workflows/publish-docs.yml |
Uses Python 3.11. |
.github/workflows/pre-commit.yml |
Uses Python 3.11. |
.github/workflows/2.build-publish.yml |
Uses Python 3.11. |
.github/workflows/1.bump-version.yml |
Uses Python 3.11. |
Review details
- Files reviewed: 12/12 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request upgrades the project to use Python 3.11 throughout the codebase and CI/CD workflows, and refactors internal type imports for better maintainability. The most significant changes are grouped below:
Python Version Upgrade:
.github/workflows/*.yml),.pre-commit-config.yaml, and.python-versionto use Python 3.11 instead of 3.10. Also added Python 3.14 to thepyproject.tomlclassifiers. [1] [2] [3] [4] [5] [6] [7]Internal Typing Refactor:
TYPE_CHECKINGblocks for Loguru types (Record,Message) with imports from the local.typingmodule insrc/beans_logging/filters.py,src/beans_logging/formats.py,src/beans_logging/rotators.py,src/beans_logging/schemas.py, andsrc/beans_logging/sinks.py. [1] [2] [3] [4] [5]RecordandMessagetypes directly, improving type clarity and consistency. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Type Alias and Callable Signature Updates:
src/beans_logging/schemas.pyto use the new directRecordandMessagetype imports for all relevant callables and unions. [1] [2]These changes ensure the project is up-to-date with Python 3.11 and improve maintainability by centralizing Loguru type definitions.