Repository navigation
Conversation
GetDNSServer sliced the resolvectl output with [:len-1], which panics (slice bounds out of range [:-1]) when the default interface reports no DNS server, as on Depot runners. Parse resolvectl output instead, fall back to the global resolvectl status and resolv.conf, and allow only the default DNS servers when no upstream server is found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some third-party Ubuntu runners (seen on Depot's
depot-ubuntu-latest), the agent crashes during startup:resolvectl status <default-iface>returns noDNS Serversline there (DNS is configured globally, not per link), so thegrep | awkoutput is empty anddnsServer[:len(dnsServer)-1]panics. The same slice on theip routeoutput panics when there is no default route.This PR:
resolvectl statusoutput in Go instead of slicing raw shell output, preferringCurrent DNS ServeroverDNS Servers;resolvectl status, then to/run/systemd/resolve/resolv.confand/etc/resolv.conf(skipping the127.0.0.53stub);GitHub-hosted runners behave the same as before: the per-link lookup still wins there.
go vet ./...andgo test ./pkg/agent/pass (linux/amd64, Go 1.26).