fix: Exclude spot instances from shadeform - #157
Merged
Merged
Conversation
drewmalin
approved these changes
Sep 17, 2026
drewmalin
deleted the
BREV-12223/fix-shadeform-instancetype-filtering
branch
September 17, 2026 19:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the Brev console, certain Shadeform Instance Types (e.g. excesssupply_B300_sxm6x8) were showing up as available, but every provision attempt failed with the error
zone has insufficient resources to fulfill the request, InsufficientCapacity.Issue:
Shadeform returns one availability entry per rental type, so a region can appear twice, once "on_demand" and once "spot", with different available values. The syncer copied each entry's available flag into "IsAvailable" without checking rental type, so a region available only as spot (available: true) marked the whole SKU as available. Since Brev provisions on-demand only, these SKUs looked bookable but always failed at create time.
Fix:
Availability.AdditionalPropertiesmap (the vendored OpenAPI client doesn't model the field yet as it seems to be outdated), with a note to switch to the typed field if the client is regenerated.