Skip to content

Cover different conduction methods in div_par_k_grad_par_mod tests - #3509

Merged
ZedThree merged 1 commit into
nextfrom
check-mms-fci-test
Oct 8, 2026
Merged

ZedThree merged 1 commit into
nextfrom
check-mms-fci-test

Conversation

@ZedThree

@ZedThree ZedThree commented Oct 8, 2026

Copy link
Copy Markdown
Member

Hopefully will help narrow down #3500

@ZedThree
ZedThree merged commit 8177bdb into next Oct 8, 2026
23 checks passed
@ZedThree
ZedThree deleted the check-mms-fci-test branch October 8, 2026 15:58
@ZedThree

ZedThree commented Oct 8, 2026

Copy link
Copy Markdown
Member Author

Wait... @dschwoerer these tests are only run for FCI, right? so the different methods aren't used here and this was a bit pointless. But we should probably also have these tests for non-FCI

@dschwoerer

dschwoerer commented Oct 9, 2026 via email

Copy link
Copy Markdown
Contributor

@ZedThree

ZedThree commented Oct 9, 2026

Copy link
Copy Markdown
Member Author

I'm not sure I follow. We fill the emplaced field before we use it. Where's the race? I must be missing something because I can't see how it would make a difference either way.

Did you also mean to point to cell_area_x* -- that's not used in this derivative. In compute_cell_area_y, we do fill then emplace, so I'm not sure that can be the explanation.

@dschwoerer

Copy link
Copy Markdown
Contributor

Indeed, I do not see how that should cause that.

https://github.com/boutproject/BOUT-dev/tree/refs/heads/openmp-race-emplace still fixes some race conditions that should be fixed, even if it is not the cause of #3500

The field aligned version of ylow / yhigh had a race conditions, but that should not affect the FCI tests, so still not sure what is going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants