Repository navigation
Fmt wrappers #3505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fmt wrappers #3505
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
aa5ea58
Add `format_as` methods delegating to existing `toString` methods
tomchapman 2f82759
Handle 's' format specification in fmt::formatter<SpecificInd<N>>
tomchapman f5ec5e0
No longer need to call `toString()` on CELL_LOC types
tomchapman 163fda2
Move fmt::formatter<SpecificInd<N>> to same file as SpecificInd is de…
tomchapman 670310a
Refactor `fmt::formatter<SpecificInd<N>>::format()` method
tomchapman 9b1ce11
Prefer const
tomchapman 4f5987c
Directly include fmt/base.h header
tomchapman d7b458e
Redundant 'typename' keyword
tomchapman 5a6048b
Clang-Tidy: add parentheses to explicitly specify the order of operat…
tomchapman 753fd1f
Clang-Tidy: Redundant parentheses around expression
tomchapman 05cc34f
Clang-Tidy: add parentheses to explicitly specify the order of operat…
tomchapman 40ad179
Clang-Tidy: Function 'createRegionIndices' has inline specifier but i…
tomchapman f15068e
Add custom formatter for DirectionTypes
tomchapman 8055c18
Restore #include utils.hxx to field.hxx
tomchapman 9a72d7f
Move `std::string toString(const DirectionTypes& dir)` from utils.hxx…
tomchapman 762b618
Add `format_as()` wrapper for BoundaryParType
tomchapman 2fab339
Remove call to `toString()` in BoutException arguments
tomchapman aca326b
Redundant 'typename' keyword
tomchapman 8e2de4f
Clang-Tidy: No header providing "BoutException" is directly included
tomchapman 0538320
Clang-Tidy: No header providing "std::set" is directly included
tomchapman c5bd564
Remove redundant `const` qualifier
tomchapman ce45224
Clang-Tidy: Pointer parameter 'localmesh' can be pointer to const
tomchapman b3719a6
Parameter can be made const
tomchapman 75a6a28
Apply clang-format
tomchapman badede6
Remove more to `toString()` calls in BoutException arguments
tomchapman c9db23a
Apply clang-format
tomchapman 0e90ad5
Add `format_as()` wrapper for ConductionMethod type
tomchapman 48363a0
Make `format_as()` parameters const (ref)
tomchapman 7b77b11
Apply clang-format
tomchapman d9b4d51
Remove unused #include "bout/utils.hxx"
tomc271 8046c2f
Restore comments in `fmt::formatter<SpecificInd<N>>`
tomchapman 2e41f70
Move `toString()` and `format_as()` methods for `DirectionTypes` belo…
tomchapman f0239f6
Revert `s` option for presentation format
tomchapman d5d1027
Remove unused #include "bout/utils.hxx"
tomchapman 8e5b27d
Move definitions and specializations of `checkFinite()` and `checkPos…
tomchapman ad83aa6
Directly include headers
tomchapman 641e54b
Revert "Move fmt::formatter<SpecificInd<N>> to same file as SpecificI…
tomchapman ff8a337
Remove unused #include directives
tomchapman 4952b23
Apply clang-format
tomchapman 5c7d768
Don't include region.hxx in field.cxx
tomchapman dd6b000
Include output_bout_types.hxx in operatorstencil.hxx
tomchapman 6033b79
Reset to original function order
tomchapman c29857c
No need to call `toString()` on a string
tomchapman d279cf5
Apply clang-format
tomchapman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -219,6 +219,10 @@ Field3D Div_par_K_Grad_par(const Field3DParallel& kY, const Field3DParallel& f, | |
| /// different results when coefficients or cell sizes vary strongly. | ||
| BOUT_ENUM_CLASS_NS(bout, ConductionMethod, Original, ProductJK, Harmonic); | ||
|
|
||
| namespace bout { | ||
| inline std::string format_as(const ConductionMethod& method) { return toString(method); } | ||
| } // namespace bout | ||
|
Comment on lines
+222
to
+224
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we add this to the |
||
|
|
||
| /// Version with energy flow diagnostic | ||
| /// For FCI fields, `flow_ylow` is currently returned as zero. | ||
| Field3D | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.