refactor: move distributed awareness to PGBL - #583
Open
Becheler wants to merge 1 commit into
Open
Conversation
|
Boost dependency footprint vs Header-inclusion weights (graph files pulling each direct dependency in): No header-inclusion-weight changes. Transitive Boost modules: 66 → 66 (0) |
|
Compiler-warning counts vs
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cross-repo change and comes with a companion PR in PBGL : boostorg/graph_parallel#47
In short: When Boost was modularized, the PBGL part moved to the
graph_parallelrepository, but the forwarding hooks,use_mpi.hpp, and the MPI build wiring remained in graph. This PR closes the migration story.Before submitting
developbranch.Type of change
Does this PR introduce a breaking change?
What this PR does
use_mpi.hpp,detail/mpi_include.hpp,detail/empty_header.hppBOOST_GRAPH_MPI_INCLUDE(...)),distributed/concepts.hppforward#ifdef BOOST_GRAPH_USE_MPIbfs_helper declaration block.pending/property_serialize.hpp(kept the two genericserialize()overloads).import mpifrombuild/Jamfile.v2Motivation
libs/graph. To let one code path run sequentially or distributed, the sequential headers included their distributed counterparts whenBOOST_GRAPH_USE_MPI. was defined. When Boost was modularized, PBGL moved to thegraph_parallelrepository, but the forwarding hooks,use_mpi.hpp, and the MPI build wiring remained in graph.5f1edca5(Peter Dimov) wrapped the includes in aBOOST_GRAPH_MPI_INCLUDEmacro to hide them fromboostdep: the reported dependency disappeared but the actual coupling did not (build/Jamfile.v2still runsimport mpi).distributed/fruchterman_reingold.hppusespoint_traitsbut no header on any include path pulls inboost/graph/point_traits.hpp. So#define BOOST_GRAPH_USE_MPI+#include <boost/graph/fruchterman_reingold.hpp>has never compiled in any release. No distributed test covers this so it went unnoticed.The user contract (remains unchanged with this PR):
It allows to write code like:
<boost/graph/use_mpi.hpp>but it ships fromgraph_parallelinstead ofgraph. Existing includes resolve unchanged.use_mpi.hppincludes all the distributed algorithm headers, a user who includes only the sequential<boost/graph/breadth_first_search.hpp>and calls it on a distributed graph still gets the distributed overload.distributed/…headers explicitly are of course unaffected.Testing
This was locally verified: 5 in-tree PBGL
tests/examplesthat rely on this pattern compiled with zero edits.Checklist
b2in thetest/directory).