exeuntu/pi-extension: preserve integration thinking levels - #6
Open
FnTm wants to merge 1 commit into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integration-backed reasoning models are currently registered without Pi’s built-in capability metadata, so they appear as non-reasoning models and lose their supported thinking levels.
We have a short-term fix in our own codebase that cooks up a static models.json override, which passes the models back in. An upstream fix seemed like a better option for everyone.
This change looks up the matching native Pi model before exe.dev adds the integration alias, then inherits only
reasoningandthinkingLevelMap. The exe.dev integration catalog remains authoritative for routing, API type, context/output limits, pricing, and display names. Unknown or custom models retain the existing pricing-catalog fallback behavior.The capability lookup is optional and defaults to a no-op, so existing callers and unit tests do not need Pi runtime modules.
Before:
After:
Validation
npm test— 26 tests passedgit diff --checkPI_CODING_AGENT_DIRand nomodels.jsonoverridegpt-4o@llm:["off"]gpt-5.5@llm:["off","low","medium","high","xhigh"]gpt-5.5-pro@llm:["medium","high","xhigh"]gpt-5.6-sol@llm:["off","low","medium","high","xhigh","max"]gpt-5.6-sol@llm --thinking highrequest completed successfully