Repository navigation
fix: pass the client's credentials option to the fetcher - #26
Merged
Merged
Conversation
The config accepted credentials but never forwarded it, so a browser client set to "include" still sent no cookies cross-origin. Co-Authored-By: LLM <noreply@maxholman.dev>
maxholman
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client's config accepts a credentials mode, but the client never passed it to the fetcher, so setting it had no effect. A browser consumer that asked for "include" so cookies would go to another origin quietly got fetch's default instead.
The built-in fetcher already forwards credentials to fetch, so only the client needed the fix. Without the fix, the new test fails.