Skip to content

fix: tankSensor liquidHeight and volume are reported in mm and ml #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbx-a merged 1 commit into from
Oct 18, 2026
Merged

fix: tankSensor liquidHeight and volume are reported in mm and ml #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions blebox_uniapi/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,9 @@ def __str__(self):
@SensorFactory.register("co2", unit="ppm")
@SensorFactory.register("co2Definition", unit="")
@SensorFactory.register("gaugePressure", unit="mbar")
@SensorFactory.register("liquidHeight", unit="cm")
@SensorFactory.register("liquidHeight", unit="cm", scale=10)
@SensorFactory.register("fillLevel", unit="percentage", scale=10)
@SensorFactory.register("volume", unit="L")
@SensorFactory.register("volume", unit="L", scale=1000)
class GenericSensor(BaseSensor):
def __init__(
# base sensor params
Expand Down
14 changes: 7 additions & 7 deletions tests/test_sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,10 +504,10 @@ def patch_version(apiLevel):
{
"multiSensor": {
"sensors": [
{"type": "gaugePressure", "id": 0, "value": 98, "state": 2},
{"type": "liquidHeight", "id": 1, "value": 100, "state": 2},
{"type": "fillLevel", "id": 2, "value": 205, "state": 2},
{"type": "volume", "id": 3, "value": 2000, "state": 2}
{"type": "gaugePressure", "id": 0, "value": 98, "state": 2},
{"type": "liquidHeight", "id": 1, "value": 1234, "state": 2},
{"type": "volume", "id": 3, "value": 2345, "state": 2}
]
}
}
Expand All @@ -520,10 +520,10 @@ def patch_version(apiLevel):
@pytest.mark.parametrize(
"index,unit,value",
[
(0, "mbar", 98),
(1, "cm", 100),
(2, "percentage", 20.5),
(3, "L", 2000),
(0, "percentage", 20.5),
(1, "mbar", 98),
(2, "cm", 123.4),
(3, "L", 2.345),
],
)
async def test_sensor_value(self, aioclient_mock, index, unit, value):
Expand Down
Loading