Rename the "shared" to "share" - #112
Merged
Merged
Conversation
SHARED_ARCH is the value substituted for the real build architecture in every path component of an architecture-independent package: install dir, tarball name, TARS store, SPECS dir and $PKGPATH. Rename it to "share" and propagate the new spelling through the paths, docstrings and warnings that spelled it out literally. generate_initdotsh() embedded the literal directory name for shared deps rather than the runtime arch prefix; it now interpolates SHARED_ARCH so the constant stays the single source of truth. test_reconstruct_layout built its expected tarball name and store-relative symlink target from a hardcoded "shared" while taking the directory from SHARED_ARCH, so it broke on the rename. It now derives all three from the constant.
Contributor
|
In principle this is fine with me to rename shared -> share but there is a lot going on in consolidation branch that changed the same two files your patch touches so, the patch does not apply cleanly. I'll make equivalent change in consolidation which I expect to merge into main and tag with new version. It is still work in progress but there are some changes to CLI that might hurt you so, you better check... Thanks, |
pbuncic
added a commit
that referenced
this pull request
Sep 10, 2026
Mirrors PR #112 onto consolidation, where SHARED_ARCH lives in arch.py. initdotsh interpolates the constant; clean.py follows it and keeps a legacy shared/ sweep. CVMFS template keys left as 'shared' on purpose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does it as it says. No functional changes.