fix(devtools): validate browser execution and cleanup - #2
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser runs with a relative
PLAYWRIGHT_CLI_BINnow resolve the executable before entering the temporary session directory. A browser-close failure reported on stderr now makes the run incomplete even if the shared wrapper exits zero, and--baselinerequires explicit--liveinstead of silently returning offline validation. Reports also include a bounded, key-redacted plan path for identifying a run without repeating URL query strings or fragments.Validated with Node 22.12.0: all 43 browser/client fixtures pass, including regressions for the relative path, close-warning, baseline-flag, and diagnostic-redaction cases.
git diff --checkpasses. Tests use stubbed commands and make no browser or provider calls. Application code and dependencies are unchanged.URL completion assertions use the canonical browser URL form. Live Jev mode also verifies its credentials and pinned model before any browser command; offline validation and the deterministic baseline remain provider-free.